Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node-exporter as DaemonSet for "K8S as cloud service" #1713

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Node-exporter as DaemonSet for "K8S as cloud service" #1713

merged 1 commit into from
Oct 2, 2020

Conversation

rpudlowski93
Copy link
Contributor

PR related to task #1673

  • added Node Exporter as DaemonSet using Helm Chart
  • added changes in Prometheus Server in order to scrap metrics from the Node Exporters
  • small necessary changes for the PR (new group variable - k8s_as_cloud_service etc..)

@rpudlowski93 rpudlowski93 changed the title [FEATURE] Node-exporter as DaemonSet for "K8S as cloud service" Node-exporter as DaemonSet for "K8S as cloud service" Sep 29, 2020
sk4zuzu
sk4zuzu previously approved these changes Oct 1, 2020
Copy link
Contributor

@sk4zuzu sk4zuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sk4zuzu
sk4zuzu previously approved these changes Oct 1, 2020
Copy link
Contributor

@atsikham atsikham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add information to changelog.

erzetpe
erzetpe previously approved these changes Oct 2, 2020
erzetpe
erzetpe previously approved these changes Oct 2, 2020
@sk4zuzu sk4zuzu marked this pull request as draft October 2, 2020 10:01
atsikham
atsikham previously approved these changes Oct 2, 2020
Kubeconfig environment added to playbook

Kubeconfig environment added to playbook

Changelog updated with Node Exporter as DaemonSet

node-exporter as DaemonSet

node-exporter as DaemonSet

node-exporter as DaemonSet

node-exporter as DaemonSet

node-exporter as DaemonSet

Removed 'Set Kubernetes credentials' task in Prometheus Role. Repository Rebased

Update core/src/epicli/data/common/ansible/playbooks/roles/node_exporter/tasks/install-node-exporter-as-system-service.yml

Co-authored-by: Michał Opala <sk4zuzu@gmail.com>

Update core/src/epicli/data/common/ansible/playbooks/roles/node_exporter/tasks/install-node-exporter-as-system-service.yml

Co-authored-by: Michał Opala <sk4zuzu@gmail.com>

Update core/src/epicli/data/common/ansible/playbooks/roles/prometheus/tasks/configure-k8s-apps-monitoring.yml

Co-authored-by: Michał Opala <sk4zuzu@gmail.com>
@rpudlowski93 rpudlowski93 dismissed stale reviews from atsikham and erzetpe via 74676a2 October 2, 2020 10:42
@rpudlowski93 rpudlowski93 marked this pull request as ready for review October 2, 2020 10:45
@rpudlowski93 rpudlowski93 merged commit 919ecbf into hitachienergy:develop Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants